483 implement javascript feature into extension to support custom javascript #625
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
View your CI Pipeline Execution ↗ for commit e96dfee
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull Request Overview
This PR implements JavaScript feature support into the extension to support custom JavaScript execution. The change enables users to create and execute JavaScript code snippets directly within the extension through a new "userscript" action type alongside existing action types.
Key changes include:
- Added support for custom JavaScript execution through a new userscript action type
- Restructured global extension state from individual window properties to a centralized
window.extobject - Updated Google Sheets integration to use the new extension state structure
Reviewed Changes
Copilot reviewed 64 out of 68 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/extension/src/lib/background/chrome/messenger/user-scripts.messenger.ts | Implements userscript execution functionality with Chrome's userScripts API |
| packages/core/common/src/lib/model/core-model.ts | Defines IExtension and ISheets interfaces for centralized extension state |
| packages/acf/common/src/lib/model/IUserscript.ts | Defines IUserScript interface and default userscript template |
| apps/acf-options-page/src/app/configs/action/userscript-row.tsx | React component for rendering userscript rows in the action table |
| apps/acf-extension/src/content_scripts/userscript.ts | Content script processor for executing userscripts |
| Multiple files | Updates to use centralized window.ext object instead of individual window properties |
Comments suppressed due to low confidence (3)
packages/core/extension/src/lib/background/chrome/messenger/user-scripts.messenger.ts:31
- The function name 'Notify' should follow camelCase convention and be more descriptive. Consider renaming it to 'notifyUserScriptsUnavailable'.
function Notify() {
packages/core/extension/src/lib/background/chrome/messenger/user-scripts.messenger.ts:33
- The variable name 'defaultOptions' is generic. Consider renaming it to 'notificationOptions' to better describe its purpose.
const defaultOptions: chrome.notifications.NotificationCreateOptions = {
packages/acf/util/src/lib/value.ts:6
- The interface name 'IValue' is too generic and doesn't clearly indicate its purpose. Consider renaming it to something more descriptive like 'IExtensionWithApi' or 'IExtendedExtension'.
interface IValue extends IExtension {
…lt action structure; improve user feedback in dropdowns
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
dharmesh-hemaram
had a problem deploying
to
Development
GitHub Actions
Failure
dharmesh-hemaram
deleted the
483-implement-javascript-feature-into-extension-to-support-custom-javascript
branch
1 participant
No description provided.